MWPW-138882: Commerce v3 Merch Card #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axelcureno
requested review from
yesil,
npeltier,
honstar,
3ch023 and
vladen
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
What's going on here? I'm also seeing CLS on desktop. Full test here. |
|
syncing stage with main
|
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #1541 +/- ##
========================================
Coverage ? 95.59%
========================================
Files ? 149
Lines ? 38355
Branches ? 0
========================================
Hits ? 36667
Misses ? 1688
Partials ? 0 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
@auniverseaway I updated the test pages as follows:
The goal is to decommission the CaaS dependency in Milo Commerce v3 on December 7th without requiring authors to update their content. Before: https://main--milo--adobecom.hlx.live/docs/library/kitchen-sink/merch-card?martech=off After: https://commerce-v3--milo--adobecom.hlx.live/docs/library/kitchen-sink/merch-card?martech=off |
honstar
added
needs-verification
|
Axelcureno
added
verified
yesil
approved these changes
Nov 16, 2023
| align-self: flex-end; | ||
| div[class*="-merch-card"] > div, | ||
| div[class*="-merch-cards"] > div { | ||
| grid-column: span 3; |
There was a problem hiding this comment.
@Axelcureno please use the suggested style, explicit span value breaks on mobile.
grid-column: span 3;
width: 100%;
grid-column: 1 / -1;
see:
vs
VKniaz
approved these changes
Nov 16, 2023
|
| if (!icons) return; | ||
| const inner = el.querySelector(`.consonant-${cardType}-inner`); | ||
| const iconWrapper = createTag('div', { class: `consonant-${cardType}-iconWrapper` }); | ||
| icons?.forEach((icon) => { |
There was a problem hiding this comment.
you already check for icons above, so can probably remove the ?
libs/blocks/merch-card/merch-card.js
Outdated
| }); | ||
| inner.prepend(iconWrapper); | ||
| const getActionMenuContent = (el, ribbonMetadata) => { | ||
| const index = (ribbonMetadata !== null) ? 1 : 0; |
There was a problem hiding this comment.
can probably remove () to match line below.
libs/blocks/merch-card/merch-card.js
Outdated
Comment on lines
86
to
92
| function getMerchCardRows(rows, ribbonMetadata, cardType, actionMenuContent) { | ||
| if (cardType === 'catalog') { | ||
| const index = ribbonMetadata === null ? 0 : 1; | ||
| return actionMenuContent !== null ? rows[index + 1] : rows[index]; | ||
| } | ||
| return rows[ribbonMetadata === null ? 0 : 1]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| function getMerchCardRows(rows, ribbonMetadata, cardType, actionMenuContent) { | |
| if (cardType === 'catalog') { | |
| const index = ribbonMetadata === null ? 0 : 1; | |
| return actionMenuContent !== null ? rows[index + 1] : rows[index]; | |
| } | |
| return rows[ribbonMetadata === null ? 0 : 1]; | |
| } | |
| function getMerchCardRows(rows, ribbonMetadata, cardType, actionMenuContent) { | |
| const index = ribbonMetadata === null ? 0 : 1; | |
| if (cardType === 'catalog') { | |
| return actionMenuContent !== null ? rows[index + 1] : rows[index]; | |
| } | |
| return rows[index]; | |
| } |
There was a problem hiding this comment.
Thanks for the suggestion, applied.
honstar
approved these changes
Nov 16, 2023
|
| 'special-offers': SPECIAL_OFFERS, | ||
| plans: PLANS_CARD, | ||
| }; | ||
| const getPodType = (styles) => { |
There was a problem hiding this comment.
super-nit: linebreak
| }; | ||
| if (altCtaMetaData !== null) decorateAlternativeCta(); | ||
| if (el.classList.contains('secure')) createSecureSign(); | ||
| cardFooter.querySelectorAll('.consonant-CardFooter-cell').forEach((cell) => cell.classList.add(`consonant-${cardType}-cell`)); |
There was a problem hiding this comment.
not sure why linter didn't flag this - line length > 100. There's actually quite a few in this file.
| const decorateRibbon = (el, ribbonMetadata, cardType) => { | ||
| const ribbonStyleRegex = /^#[0-9a-fA-F]+, #[0-9a-fA-F]+$/; | ||
| if (!ribbonStyleRegex.test(ribbonMetadata[0]?.innerText)) return; | ||
| const ribbonStyle = ribbonMetadata[0].innerText; |
There was a problem hiding this comment.
should this be trimmed?
libs/blocks/merch-card/merch-card.js
Outdated
Comment on lines
11
to
12
| const cardTypes = ['segment', 'special-offers', 'plans', 'catalog', 'product', 'inline-heading']; | ||
| const merchCardGrids = ['one-merch-card', 'two-merch-cards', 'three-merch-cards', 'four-merch-cards']; |
There was a problem hiding this comment.
nit: ALL_CAPS for actual constants.
vladen
approved these changes
Nov 16, 2023
|
|
|
chrischrischris
approved these changes
Nov 16, 2023
JackySun9
added a commit
that referenced
this pull request
Jan 23, 2024
* MWPW-138684: Fix merch block for safari (#1474) * MWPW-138684: Fix merch issue on Safari --------- Co-authored-by: Denis Vlassenko <[email protected]> * MWPW-138740: fix strikethrough price (#1478) * [MWPW-137523] Add dark and large styles for quiet marquee (#1454) * add dark and large styles for quiet marquee * reduce :is() confusion * MWPW-138223 - Aside - max width on large notifications (#1470) * notification large center to be 800px max width * notification large center flex direction columns * fixed style lint errors in blocks/aside/aside.css * Revert "[MWPW-137523] Add dark and large styles for quiet marquee" (#1483) * MWPW-136763: Fixes wrong origins being used by consumers #1325 (#1487) * MWPW-136763: Fixes wrong origins being used by consumers (#1325) * Fixes wrong origins being used by consumers * Adding whitespace per feedback comment * removing mappings that already are the same as origin * Fixing linting issues * Fixing issue where consumer origins were being clipped when send to caas --------- Co-authored-by: Chris Millar <[email protected]> * hello * Revert utils --------- Co-authored-by: Chris Millar <[email protected]> * MWPW-136763: Fixes cases where origin is not in mapping (#1488) Fixes cases where origin is not in mapping * Add analytics to 404 page template (#1477) * Add analytics to centralized 404 page * Update 404.js * MWPW-130730 - Geo modal CTA highlight inconsistency (#1439) * Geo modal CTA highlight inconsistency --------- Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * Implemented disabling scroll when modal with curtain is opened (#1466) * Implemented disabling scroll when modal with curtain is opened * MWPW-138106: b.a.com Blog category titles fix (#1472) * First * Adding some string sanatization to taxonomy * Removing console.log * Adjusting based on CR * initial commit for dynamic tutorials * fix eslint * fix(MWPW-133207):Intermittent screen freeze, backdrop does not close when modal is closed. (#1436) * fix for screen freeze issue * changed selector from id to class * modal-curtain is closed only if it exists * close backdrop only if the identified element is a dialog-modal --------- Co-authored-by: Aaron Mauchley <[email protected]> * MWPW-138808 Apply leaner fix for merch card prices (web components) (#1490) MWPW-138808 Apply leaner fix for merch web components Co-authored-by: Honwai Wong <[email protected]> * MWPW-137073: Github action to sync repos (#1496) - Uses Floodgate Sync Repo github app to generate the auth token and sync the source and the equivalent FG repo as setup in the script - The workflow runs only on demand and can be triggered from the Actions tab as and when needed * MWPW-137448 - Point Stage to Acom Reviews on www.stage.adobe.com (#1393) * MWPW-137448 - Point Stage to Acom Reviews on www.stage.adobe.com Co-authored-by: Dragana Trajkovic <[email protected]> * add enter event for input box * MWPW-137301 XXL Button Style (#1473) * Update caas.css * MWPW-135425 - Remove icon width limit on small notif aside (#1479) * fix small icon width and stylelint errors * MWPW-138223 - Aside - max width on large notifications (#1470) * notification large center to be 800px max width * notification large center flex direction columns * fixed style lint errors in blocks/aside/aside.css * Revert "[MWPW-137523] Add dark and large styles for quiet marquee" (#1483) * MWPW-136763: Fixes wrong origins being used by consumers #1325 (#1487) * MWPW-136763: Fixes wrong origins being used by consumers (#1325) * Fixes wrong origins being used by consumers * Adding whitespace per feedback comment * removing mappings that already are the same as origin * Fixing linting issues * Fixing issue where consumer origins were being clipped when send to caas --------- Co-authored-by: Chris Millar <[email protected]> * hello * Revert utils --------- Co-authored-by: Chris Millar <[email protected]> * MWPW-136763: Fixes cases where origin is not in mapping (#1488) Fixes cases where origin is not in mapping * Add analytics to 404 page template (#1477) * Add analytics to centralized 404 page * Update 404.js * MWPW-130730 - Geo modal CTA highlight inconsistency (#1439) * Geo modal CTA highlight inconsistency --------- Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * re-apply icon fix on top of merged css * revert squirrely spacing --------- Co-authored-by: Sean Archibeque <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Sanjay Rai <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * MWPW-137523 - Increase large quiet marquee max-width (#1512) * add dark and large styles for quiet marquee * reduce :is() confusion * revert dark mode quiet marquee for now * clean up commit * clean up again * MWPW-137866: Web component-based Merch Card in Milo (#1504) * web component merch card in Milo * unit tests, dynamic import, css * lint fixes * minor style fixes to catalog card * web component update --------- Co-authored-by: Mariia Lukianets <[email protected]> * MWPW-138185 Update Marketo Intersection Observer (#1500) * Revert "MWPW-137866: Web component-based Merch Card in Milo" (#1521) Revert "MWPW-137866: Web component-based Merch Card in Milo (#1504)" This reverts commit 082c30d2da9289caae19fceaf1586193cf3c2ca9. * MWPW-129984 Contextual Search without Helpx (#1493) * MWPW-129984 Contextual Search without Helpx * MWPW-138197 Fix Adobe Logo on Safari (#1518) * MWPW-138197 Fix Adobe Logo on Safari * cr * MWPW-138822: Quiz debugging features; bug fixes (#1524) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15e3f1638d1a466c350dbc1b610a07bb25c. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-138713: [Q] Bogus dependency of step indicator on background (#1482) --------- Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-137634 footer unit tests (#1471) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * Improving Code Readability * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * increased branches code coverage for global footer --------- Co-authored-by: Narcis Radu <[email protected]> * MWPW-138921 Fixing popup promo image size (#1516) With rearrangement of CSS in #1470 the promoaside icon styles are overriding promoaside popup variant icon styles. Fixing the css to prioritize popup style for popup promo. Resolves: MWPW-138921 Test URLs: Before: https://main--milo--adobecom.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off After: https://mwpw-138921--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off * MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440) * grid-width section support for .contained content * Conditional check for authored section up styles. * PR refactor feedback * Added test coverage for new chart functionality w/ section-meta styles * Delete robots.txt * Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update" (#1534) Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440)" This reverts commit 487471477c6f7d165a6afb6f01e373d1aec2fd6e. * Add workflow to run Nala tests on CircleCI for Milo Stage (#1533) Add workflow to run tests on CircleCI for Stage Co-authored-by: Aaron Mauchley <[email protected]> * Syncing Stage (#1538) Getting stage in sync w/ main * Support for prod non milo environment (#1537) * Create robots.txt * Create robots.txt * Syncing stage with main (#1544) syncing stage with main * MWPW-138347 Font display optional (#1535) * MWPW-132986 - Add spacing around library blocks (#1438) * Block spacing * Add spacing to blocks copied and pasted from the block library. * Removing spacing from getHtml to avoid duplicate spacing being added to grouped patterns. Adding spacing to the new blob. --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> * MWPW-138962: Bacom-blog Article Feed Issue (#1513) * Adding some logic to determine which project is loading article feed * Adding null operator * MWPW-138565 | Gnav overlapping with popup promobar (#1519) Popup promobar takes a 16px gap from the bottom to have a floating effect. The current bottom attribute is making the promobar overlap with the Gnav. Changing the bottom attribute and applying it on section so that the promobar does not overlap with gnav when previewed in fragment. Sample page links - https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud-default Resolves: MWPW-138565 Test URLs: Before: https://main--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off After: https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off * MWPW-139338: mocked ims for gnav.js unit tests (#1545) mocked ims for gnav.js unit tests * [MWPW-139039] Table css update for RTL (#1549) rtl styles for table. * Sync (#1551) Hopefully the last sync of main into stage. * MWPW-139365 - SEO Tab Canonical Fix * Fix canonical being absent hanging all other SEO checks * Mwpw 139041 sidekick (#1552) * MWPW-129984 Contextual Search without Helpx (#1493) * MWPW-129984 Contextual Search without Helpx * MWPW-138197 Fix Adobe Logo on Safari (#1518) * MWPW-138197 Fix Adobe Logo on Safari * cr * MWPW-138822: Quiz debugging features; bug fixes (#1524) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15e3f1638d1a466c350dbc1b610a07bb25c. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-138713: [Q] Bogus dependency of step indicator on background (#1482) --------- Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-137634 footer unit tests (#1471) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * Improving Code Readability * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * increased branches code coverage for global footer --------- Co-authored-by: Narcis Radu <[email protected]> * MWPW-138921 Fixing popup promo image size (#1516) With rearrangement of CSS in #1470 the promoaside icon styles are overriding promoaside popup variant icon styles. Fixing the css to prioritize popup style for popup promo. Resolves: MWPW-138921 Test URLs: Before: https://main--milo--adobecom.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off After: https://mwpw-138921--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off * MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440) * grid-width section support for .contained content * Conditional check for authored section up styles. * PR refactor feedback * Added test coverage for new chart functionality w/ section-meta styles * Delete robots.txt * Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update" (#1534) Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440)" This reverts commit 487471477c6f7d165a6afb6f01e373d1aec2fd6e. * Add workflow to run Nala tests on CircleCI for Milo Stage (#1533) Add workflow to run tests on CircleCI for Stage Co-authored-by: Aaron Mauchley <[email protected]> * Support for prod non milo environment (#1537) * Create robots.txt * MWPW-138347 Font display optional (#1535) * MWPW-132986 - Add spacing around library blocks (#1438) * Block spacing * Add spacing to blocks copied and pasted from the block library. * Removing spacing from getHtml to avoid duplicate spacing being added to grouped patterns. Adding spacing to the new blob. --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> * MWPW-138962: Bacom-blog Article Feed Issue (#1513) * Adding some logic to determine which project is loading article feed * Adding null operator * MWPW-138565 | Gnav overlapping with popup promobar (#1519) Popup promobar takes a 16px gap from the bottom to have a floating effect. The current bottom attribute is making the promobar overlap with the Gnav. Changing the bottom attribute and applying it on section so that the promobar does not overlap with gnav when previewed in fragment. Sample page links - https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud-default Resolves: MWPW-138565 Test URLs: Before: https://main--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off After: https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off * MWPW-139338: mocked ims for gnav.js unit tests (#1545) mocked ims for gnav.js unit tests * mwpw-139041 Sidekick breaks if merch link is used --------- Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Shahbaz Khan <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: vivgoodrich <[email protected]> * MWPW-138882: Commerce v3 Merch Card (#1541) Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: Shahbaz Khan <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Fix Adobe Logo on Safari (#1518) fixes (#1524) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) Fixing issue when there are more than one rule with same number of grouping (#1112) Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) fix (#1153) Fix Acessibility warning (#1192) Fixing the issue of NOT operator when the order of selection is changed (#1200) Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) Resolves quiz-results.js feedback in PR #1264 Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) Fixing stuffs to make performance great again.. (#1429) Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Fixing popup promo image size (#1516) * MWPW-136383 - Add off-origin ability to links.js (#1455) * Add off-origin ability to links.js If off-origin keyword is set in links.json any link that doesn't match the site origin will open in a new tab. More detailed explanatory text. Wrap at 72 characters. * Adding unit tests --------- Co-authored-by: Ryan Clayton <[email protected]> * chore: remove bulk user caching * trivial: Update LICENSE (#1558) * trivial: Update LICENSE (#1558) * [MWPW-136943] Colorful Gnav headings for A/B test (#1532) * [MWPW-136943] Colorful Gnav headings for A/B test * [MWPW-136943] Fix gnav colorful headings caret size * [MWPW-136943] Merge stage to main (#1561) * trivial: Update LICENSE (#1558) * [MWPW-136943] Colorful Gnav headings for A/B test (#1532) * [MWPW-136943] Colorful Gnav headings for A/B test * [MWPW-136943] Fix gnav colorful headings caret size --------- Co-authored-by: Chris Millar <[email protected]> * [MWPW-139201] Allow CTAs in Gnav Promo boxes (#1548) * [MWPW-139201] Allow CTAs in Gnav Promo boxes (#1562) * MWPW-138986 Fix chart sum with decimals (#1540) * MWPW-138577: Global footer logging (#1514) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * feat: added lana logging to the global-footer * hotfix * hotfix * feat: added unit tests for footer logging * Improving Code Readability * hotfix * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * hotfixes * increased branches code coverage for global footer * unit tests for global footer logs * fixed rebase error * fixed sinon sub error on global footer tests * mocked ims for gnav.js unit tests * hotfix * optimizing * added unit test for logs when footer cannot be instantiated * optimizing --------- Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-135656: refactor region selector and social links decoration (#1560) * trivial: Update LICENSE (#1558) * refactor: decorate links logic * hotfix * improved decorate content logic on global-footer --------- Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-139041 Unit Test Fix v2 (#1574) mwpw-139041-ut-fix-v2 Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-135830 - Decorate Area for fragments (#1520) * mediaPrefix for medias on adobe.com root * remove mediaPrefix, added decorateArea and run it before decorating area * decorateArea() on fragments * remove unwanted change * replaceDotMedia() * restoring decorateArea(doc) * remove replaceDotMedia since it will be handled from #1523 * remove the test * same as before * added test for decorateArea() --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-139127 - Relative Fragment Media (#1523) * MWPW-139127 - Relative Fragment Media * Make media URLs relative to fragment path * Update libs/blocks/fragment/fragment.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * MWPW-139841 - Added icon symbol `arrow-down` to icons.svg (#1593) Added icon symbol `arrow-down` to icons.svg * MWPW-136152 🆕 `quiz-marquee` block for the app recommender landing page (#1510) * initial quiz marquee * updated to quiz-marquee * Few style supports for inline-headline * renamed variant icon-inline * styling addressed for icon.notification, text * quiz marquee styles * few style adjustments * per-viewport on text block authoring * Fixed some tablet views and altered the naming convention for buttons * format icons * no btn-justified by default. * Supporting flex align for per viewport queries, Icons sizing * Sync on global button styles update * min width on icon inline text * flex on viewport containers * refactor the per-viewport text func * defatult size con con-button not justified. added thru block * added some cls min-heights and adjusted margins * Added tests for the Biz markie * removed unused func * text test coverage for per-viewport content * merge conflicts * lint test * Few PR feedback items. Refactor scripts. clearer test lang. optimze func * hex value for badge * trivial: Update LICENSE (#1558) * refactored the decorateIcon to be only on the Text block to isolate its need * [MWPW-136943] Colorful Gnav headings for A/B test (#1532) * [MWPW-136943] Colorful Gnav headings for A/B test * [MWPW-136943] Fix gnav colorful headings caret size * [MWPW-139201] Allow CTAs in Gnav Promo boxes (#1548) * Minor nit PR feedback, added line to codeowners * text-block .icon area.con-button no gap * added alignment for .icon-area --------- Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> * MWPW-137835 - Tabs new 'pill' variant with sizes (#1543) * Tabs pill variant and styles --------- Co-authored-by: Blaine Gunn <[email protected]> * Mwpw 139503: Merch Card link & block analytics (#1599) * link and block analytics for merch card * unti tests and safe check * optional chaining * nle safe check --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-139317 Remove 0 from article card (#1585) * Mwpw-138750 analytics update 2.1 (#1531) * mwpw-138750 analytics update 2.0 * pass placeholders from Target * override and full url * remove unneeded if * add manifestUrl to Target * add if back in to prevent duplicates * add analytics btn and fix btn if Trgt on & no rtrn * shorten analytics off title * add indent to page button info * make variantLable lower case for compare * add ? if variantLabel is null * merge manifest-utils into personalization * remove 2 manifest-utils references * remove 1 import of manifest-utils * remove redundant function * rework promise syntax * update to "analytics manifest name" * consolidate call of preview button * update unit tests * change controlPageLoad to true * move functions to attributes.js * streamline return line * update regex for non latin alphabet * remove empty line * requested updates from Peyer * restore constants in attributes * mwpw-139041-ut-fix-v2 * rebase * update normalizePath to other version * ut coverage --------- Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-139169 - Vertically center aside notification icon (#1530) * vertically center aside notification icon area * change fixed height to max height --------- Co-authored-by: Blaine Gunn <[email protected]> * MWPW-139129,MWPW-138514,MWPW-138654: Error handling, Progress bar, Background images (#1529) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15e3f1638d1a466c350dbc1b610a07bb25c. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]…
JackySun9
added a commit
that referenced
this pull request
Jan 26, 2024
* MWPW-138684: Fix merch block for safari (#1474) * MWPW-138684: Fix merch issue on Safari --------- Co-authored-by: Denis Vlassenko <[email protected]> * MWPW-138740: fix strikethrough price (#1478) * [MWPW-137523] Add dark and large styles for quiet marquee (#1454) * add dark and large styles for quiet marquee * reduce :is() confusion * MWPW-138223 - Aside - max width on large notifications (#1470) * notification large center to be 800px max width * notification large center flex direction columns * fixed style lint errors in blocks/aside/aside.css * Revert "[MWPW-137523] Add dark and large styles for quiet marquee" (#1483) * MWPW-136763: Fixes wrong origins being used by consumers #1325 (#1487) * MWPW-136763: Fixes wrong origins being used by consumers (#1325) * Fixes wrong origins being used by consumers * Adding whitespace per feedback comment * removing mappings that already are the same as origin * Fixing linting issues * Fixing issue where consumer origins were being clipped when send to caas --------- Co-authored-by: Chris Millar <[email protected]> * hello * Revert utils --------- Co-authored-by: Chris Millar <[email protected]> * MWPW-136763: Fixes cases where origin is not in mapping (#1488) Fixes cases where origin is not in mapping * Add analytics to 404 page template (#1477) * Add analytics to centralized 404 page * Update 404.js * MWPW-130730 - Geo modal CTA highlight inconsistency (#1439) * Geo modal CTA highlight inconsistency --------- Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * Implemented disabling scroll when modal with curtain is opened (#1466) * Implemented disabling scroll when modal with curtain is opened * MWPW-138106: b.a.com Blog category titles fix (#1472) * First * Adding some string sanatization to taxonomy * Removing console.log * Adjusting based on CR * initial commit for dynamic tutorials * fix eslint * fix(MWPW-133207):Intermittent screen freeze, backdrop does not close when modal is closed. (#1436) * fix for screen freeze issue * changed selector from id to class * modal-curtain is closed only if it exists * close backdrop only if the identified element is a dialog-modal --------- Co-authored-by: Aaron Mauchley <[email protected]> * MWPW-138808 Apply leaner fix for merch card prices (web components) (#1490) MWPW-138808 Apply leaner fix for merch web components Co-authored-by: Honwai Wong <[email protected]> * MWPW-137073: Github action to sync repos (#1496) - Uses Floodgate Sync Repo github app to generate the auth token and sync the source and the equivalent FG repo as setup in the script - The workflow runs only on demand and can be triggered from the Actions tab as and when needed * MWPW-137448 - Point Stage to Acom Reviews on www.stage.adobe.com (#1393) * MWPW-137448 - Point Stage to Acom Reviews on www.stage.adobe.com Co-authored-by: Dragana Trajkovic <[email protected]> * add enter event for input box * MWPW-137301 XXL Button Style (#1473) * Update caas.css * MWPW-135425 - Remove icon width limit on small notif aside (#1479) * fix small icon width and stylelint errors * MWPW-138223 - Aside - max width on large notifications (#1470) * notification large center to be 800px max width * notification large center flex direction columns * fixed style lint errors in blocks/aside/aside.css * Revert "[MWPW-137523] Add dark and large styles for quiet marquee" (#1483) * MWPW-136763: Fixes wrong origins being used by consumers #1325 (#1487) * MWPW-136763: Fixes wrong origins being used by consumers (#1325) * Fixes wrong origins being used by consumers * Adding whitespace per feedback comment * removing mappings that already are the same as origin * Fixing linting issues * Fixing issue where consumer origins were being clipped when send to caas --------- Co-authored-by: Chris Millar <[email protected]> * hello * Revert utils --------- Co-authored-by: Chris Millar <[email protected]> * MWPW-136763: Fixes cases where origin is not in mapping (#1488) Fixes cases where origin is not in mapping * Add analytics to 404 page template (#1477) * Add analytics to centralized 404 page * Update 404.js * MWPW-130730 - Geo modal CTA highlight inconsistency (#1439) * Geo modal CTA highlight inconsistency --------- Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * re-apply icon fix on top of merged css * revert squirrely spacing --------- Co-authored-by: Sean Archibeque <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Sanjay Rai <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * MWPW-137523 - Increase large quiet marquee max-width (#1512) * add dark and large styles for quiet marquee * reduce :is() confusion * revert dark mode quiet marquee for now * clean up commit * clean up again * MWPW-137866: Web component-based Merch Card in Milo (#1504) * web component merch card in Milo * unit tests, dynamic import, css * lint fixes * minor style fixes to catalog card * web component update --------- Co-authored-by: Mariia Lukianets <[email protected]> * MWPW-138185 Update Marketo Intersection Observer (#1500) * Revert "MWPW-137866: Web component-based Merch Card in Milo" (#1521) Revert "MWPW-137866: Web component-based Merch Card in Milo (#1504)" This reverts commit 082c30d2da9289caae19fceaf1586193cf3c2ca9. * MWPW-129984 Contextual Search without Helpx (#1493) * MWPW-129984 Contextual Search without Helpx * MWPW-138197 Fix Adobe Logo on Safari (#1518) * MWPW-138197 Fix Adobe Logo on Safari * cr * MWPW-138822: Quiz debugging features; bug fixes (#1524) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15e3f1638d1a466c350dbc1b610a07bb25c. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-138713: [Q] Bogus dependency of step indicator on background (#1482) --------- Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-137634 footer unit tests (#1471) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * Improving Code Readability * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * increased branches code coverage for global footer --------- Co-authored-by: Narcis Radu <[email protected]> * MWPW-138921 Fixing popup promo image size (#1516) With rearrangement of CSS in #1470 the promoaside icon styles are overriding promoaside popup variant icon styles. Fixing the css to prioritize popup style for popup promo. Resolves: MWPW-138921 Test URLs: Before: https://main--milo--adobecom.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off After: https://mwpw-138921--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off * MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440) * grid-width section support for .contained content * Conditional check for authored section up styles. * PR refactor feedback * Added test coverage for new chart functionality w/ section-meta styles * Delete robots.txt * Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update" (#1534) Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440)" This reverts commit 487471477c6f7d165a6afb6f01e373d1aec2fd6e. * Add workflow to run Nala tests on CircleCI for Milo Stage (#1533) Add workflow to run tests on CircleCI for Stage Co-authored-by: Aaron Mauchley <[email protected]> * Syncing Stage (#1538) Getting stage in sync w/ main * Support for prod non milo environment (#1537) * Create robots.txt * Create robots.txt * Syncing stage with main (#1544) syncing stage with main * MWPW-138347 Font display optional (#1535) * MWPW-132986 - Add spacing around library blocks (#1438) * Block spacing * Add spacing to blocks copied and pasted from the block library. * Removing spacing from getHtml to avoid duplicate spacing being added to grouped patterns. Adding spacing to the new blob. --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> * MWPW-138962: Bacom-blog Article Feed Issue (#1513) * Adding some logic to determine which project is loading article feed * Adding null operator * MWPW-138565 | Gnav overlapping with popup promobar (#1519) Popup promobar takes a 16px gap from the bottom to have a floating effect. The current bottom attribute is making the promobar overlap with the Gnav. Changing the bottom attribute and applying it on section so that the promobar does not overlap with gnav when previewed in fragment. Sample page links - https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud-default Resolves: MWPW-138565 Test URLs: Before: https://main--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off After: https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off * MWPW-139338: mocked ims for gnav.js unit tests (#1545) mocked ims for gnav.js unit tests * [MWPW-139039] Table css update for RTL (#1549) rtl styles for table. * Sync (#1551) Hopefully the last sync of main into stage. * MWPW-139365 - SEO Tab Canonical Fix * Fix canonical being absent hanging all other SEO checks * Mwpw 139041 sidekick (#1552) * MWPW-129984 Contextual Search without Helpx (#1493) * MWPW-129984 Contextual Search without Helpx * MWPW-138197 Fix Adobe Logo on Safari (#1518) * MWPW-138197 Fix Adobe Logo on Safari * cr * MWPW-138822: Quiz debugging features; bug fixes (#1524) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15e3f1638d1a466c350dbc1b610a07bb25c. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-138713: [Q] Bogus dependency of step indicator on background (#1482) --------- Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-137634 footer unit tests (#1471) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * Improving Code Readability * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * increased branches code coverage for global footer --------- Co-authored-by: Narcis Radu <[email protected]> * MWPW-138921 Fixing popup promo image size (#1516) With rearrangement of CSS in #1470 the promoaside icon styles are overriding promoaside popup variant icon styles. Fixing the css to prioritize popup style for popup promo. Resolves: MWPW-138921 Test URLs: Before: https://main--milo--adobecom.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off After: https://mwpw-138921--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off * MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440) * grid-width section support for .contained content * Conditional check for authored section up styles. * PR refactor feedback * Added test coverage for new chart functionality w/ section-meta styles * Delete robots.txt * Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update" (#1534) Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440)" This reverts commit 487471477c6f7d165a6afb6f01e373d1aec2fd6e. * Add workflow to run Nala tests on CircleCI for Milo Stage (#1533) Add workflow to run tests on CircleCI for Stage Co-authored-by: Aaron Mauchley <[email protected]> * Support for prod non milo environment (#1537) * Create robots.txt * MWPW-138347 Font display optional (#1535) * MWPW-132986 - Add spacing around library blocks (#1438) * Block spacing * Add spacing to blocks copied and pasted from the block library. * Removing spacing from getHtml to avoid duplicate spacing being added to grouped patterns. Adding spacing to the new blob. --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> * MWPW-138962: Bacom-blog Article Feed Issue (#1513) * Adding some logic to determine which project is loading article feed * Adding null operator * MWPW-138565 | Gnav overlapping with popup promobar (#1519) Popup promobar takes a 16px gap from the bottom to have a floating effect. The current bottom attribute is making the promobar overlap with the Gnav. Changing the bottom attribute and applying it on section so that the promobar does not overlap with gnav when previewed in fragment. Sample page links - https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud-default Resolves: MWPW-138565 Test URLs: Before: https://main--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off After: https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off * MWPW-139338: mocked ims for gnav.js unit tests (#1545) mocked ims for gnav.js unit tests * mwpw-139041 Sidekick breaks if merch link is used --------- Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Shahbaz Khan <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: vivgoodrich <[email protected]> * MWPW-138882: Commerce v3 Merch Card (#1541) Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: Shahbaz Khan <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Fix Adobe Logo on Safari (#1518) fixes (#1524) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) Fixing issue when there are more than one rule with same number of grouping (#1112) Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) fix (#1153) Fix Acessibility warning (#1192) Fixing the issue of NOT operator when the order of selection is changed (#1200) Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) Resolves quiz-results.js feedback in PR #1264 Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) Fixing stuffs to make performance great again.. (#1429) Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Fixing popup promo image size (#1516) * MWPW-136383 - Add off-origin ability to links.js (#1455) * Add off-origin ability to links.js If off-origin keyword is set in links.json any link that doesn't match the site origin will open in a new tab. More detailed explanatory text. Wrap at 72 characters. * Adding unit tests --------- Co-authored-by: Ryan Clayton <[email protected]> * chore: remove bulk user caching * trivial: Update LICENSE (#1558) * trivial: Update LICENSE (#1558) * [MWPW-136943] Colorful Gnav headings for A/B test (#1532) * [MWPW-136943] Colorful Gnav headings for A/B test * [MWPW-136943] Fix gnav colorful headings caret size * [MWPW-136943] Merge stage to main (#1561) * trivial: Update LICENSE (#1558) * [MWPW-136943] Colorful Gnav headings for A/B test (#1532) * [MWPW-136943] Colorful Gnav headings for A/B test * [MWPW-136943] Fix gnav colorful headings caret size --------- Co-authored-by: Chris Millar <[email protected]> * [MWPW-139201] Allow CTAs in Gnav Promo boxes (#1548) * [MWPW-139201] Allow CTAs in Gnav Promo boxes (#1562) * MWPW-138986 Fix chart sum with decimals (#1540) * MWPW-138577: Global footer logging (#1514) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * feat: added lana logging to the global-footer * hotfix * hotfix * feat: added unit tests for footer logging * Improving Code Readability * hotfix * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * hotfixes * increased branches code coverage for global footer * unit tests for global footer logs * fixed rebase error * fixed sinon sub error on global footer tests * mocked ims for gnav.js unit tests * hotfix * optimizing * added unit test for logs when footer cannot be instantiated * optimizing --------- Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-135656: refactor region selector and social links decoration (#1560) * trivial: Update LICENSE (#1558) * refactor: decorate links logic * hotfix * improved decorate content logic on global-footer --------- Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-139041 Unit Test Fix v2 (#1574) mwpw-139041-ut-fix-v2 Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-135830 - Decorate Area for fragments (#1520) * mediaPrefix for medias on adobe.com root * remove mediaPrefix, added decorateArea and run it before decorating area * decorateArea() on fragments * remove unwanted change * replaceDotMedia() * restoring decorateArea(doc) * remove replaceDotMedia since it will be handled from #1523 * remove the test * same as before * added test for decorateArea() --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-139127 - Relative Fragment Media (#1523) * MWPW-139127 - Relative Fragment Media * Make media URLs relative to fragment path * Update libs/blocks/fragment/fragment.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * MWPW-139841 - Added icon symbol `arrow-down` to icons.svg (#1593) Added icon symbol `arrow-down` to icons.svg * MWPW-136152 🆕 `quiz-marquee` block for the app recommender landing page (#1510) * initial quiz marquee * updated to quiz-marquee * Few style supports for inline-headline * renamed variant icon-inline * styling addressed for icon.notification, text * quiz marquee styles * few style adjustments * per-viewport on text block authoring * Fixed some tablet views and altered the naming convention for buttons * format icons * no btn-justified by default. * Supporting flex align for per viewport queries, Icons sizing * Sync on global button styles update * min width on icon inline text * flex on viewport containers * refactor the per-viewport text func * defatult size con con-button not justified. added thru block * added some cls min-heights and adjusted margins * Added tests for the Biz markie * removed unused func * text test coverage for per-viewport content * merge conflicts * lint test * Few PR feedback items. Refactor scripts. clearer test lang. optimze func * hex value for badge * trivial: Update LICENSE (#1558) * refactored the decorateIcon to be only on the Text block to isolate its need * [MWPW-136943] Colorful Gnav headings for A/B test (#1532) * [MWPW-136943] Colorful Gnav headings for A/B test * [MWPW-136943] Fix gnav colorful headings caret size * [MWPW-139201] Allow CTAs in Gnav Promo boxes (#1548) * Minor nit PR feedback, added line to codeowners * text-block .icon area.con-button no gap * added alignment for .icon-area --------- Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> * MWPW-137835 - Tabs new 'pill' variant with sizes (#1543) * Tabs pill variant and styles --------- Co-authored-by: Blaine Gunn <[email protected]> * Mwpw 139503: Merch Card link & block analytics (#1599) * link and block analytics for merch card * unti tests and safe check * optional chaining * nle safe check --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-139317 Remove 0 from article card (#1585) * Mwpw-138750 analytics update 2.1 (#1531) * mwpw-138750 analytics update 2.0 * pass placeholders from Target * override and full url * remove unneeded if * add manifestUrl to Target * add if back in to prevent duplicates * add analytics btn and fix btn if Trgt on & no rtrn * shorten analytics off title * add indent to page button info * make variantLable lower case for compare * add ? if variantLabel is null * merge manifest-utils into personalization * remove 2 manifest-utils references * remove 1 import of manifest-utils * remove redundant function * rework promise syntax * update to "analytics manifest name" * consolidate call of preview button * update unit tests * change controlPageLoad to true * move functions to attributes.js * streamline return line * update regex for non latin alphabet * remove empty line * requested updates from Peyer * restore constants in attributes * mwpw-139041-ut-fix-v2 * rebase * update normalizePath to other version * ut coverage --------- Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-139169 - Vertically center aside notification icon (#1530) * vertically center aside notification icon area * change fixed height to max height --------- Co-authored-by: Blaine Gunn <[email protected]> * MWPW-139129,MWPW-138514,MWPW-138654: Error handling, Progress bar, Background images (#1529) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15e3f1638d1a466c350dbc1b610a07bb25c. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <xiasun@x…
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: Shahbaz Khan <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Fix Adobe Logo on Safari (adobecom#1518) fixes (adobecom#1524) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) Fixing issue when there are more than one rule with same number of grouping (adobecom#1112) Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) fix (adobecom#1153) Fix Acessibility warning (adobecom#1192) Fixing the issue of NOT operator when the order of selection is changed (adobecom#1200) Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) Resolves quiz-results.js feedback in PR adobecom#1264 Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) Fixing stuffs to make performance great again.. (adobecom#1429) Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Fixing popup promo image size (adobecom#1516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWPW-137866: Introduces an all-new merch card block built using Lit Web Components.
Introduces Lit library and merch-card lit-based dependencies inside /deps folder in Milo.
What's new:
The differentiator between the old merch card and the new one will be the section metadata column grid designation.
Old merch card uses: One up, two up, three up, four up.
New merch card uses: one merch card, two merch cards, three merch cards, four merch cards.
If no column grid designation is set in section metadata, a 3-column setting is automatically applied (same as current behavior using caas CSS)
New text-style based approach
To better align with Consonant designs and have authored cards be more consistent, this change introduces a new text-style based approach mapping Sharepoint headings (Heading 1, Heading 2, Heading 3, Heading 4, Heading 5) mapped to Merch Card Consonant styles.
The mapping is the following:
H5: Detail M
H4: Body XXS
H3: Heading XS
H2: Heading M
H1: heading L
Paragraph: Body XS
Backward compatibility scenario to show no impact on existing merch card block: https://mwpw-137866--milo--axelcureno.hlx.page/docs/library/kitchen-sink/merch-card
Resolves: MWPW-137866
Test URLs:
Before: https://main--cc--adobecom.hlx.page/drafts/axel/merch-card-docs/merch-card
After: https://main--cc--adobecom.hlx.page/drafts/axel/merch-card-docs/merch-card?milolibs=commerce-v3